Issue 150229: Handle partial sends over the ChromeDevToolsProtocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150229: Handle partial sends over the ChromeDevToolsProtocol (Closed)

Created:
11 years, 5 months ago by apavlov

Modified:
9 years, 7 months ago

Reviewers:
pfeldman

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Handle partial sends over the ChromeDevToolsProtocol. send() can send parts of the buffer fed in. We should send parts of the buffer until the entire buffer has been transferred. TEST = related DevTools* tests pass + manually tested that there is no data loss (where it used to be) on Windows XP, Ubuntu 8.04, MaxOS X BUG = none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19902

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -9 lines)			Patch
	M	chrome/browser/debugger/devtools_remote_listen_socket.cc	View		1 chunk	+22 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages