Issue 150219: DevTools: Move InspectorController message filtering to the injected side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150219: DevTools: Move InspectorController message filtering to the injected side. (Closed)

Created:
11 years, 5 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: Move InspectorController message filtering to the injected side. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19806

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -9 lines)			Patch
	M	webkit/glue/devtools/js/devtools.js	View		1 chunk	+1 line, -9 lines	0 comments	Download
	M	webkit/glue/devtools/js/inject_dispatch.js	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

http://codereview.chromium.org/150219/diff/1/2 File webkit/glue/devtools/js/inject_dispatch.js (right): http://codereview.chromium.org/150219/diff/1/2#newcode51 Line 51: method == 'reset' || wrong alignment

11 years, 5 months ago (2009-07-02 10:27:13 UTC) #2

yurys

On 2009/07/02 10:27:13, Yury Semikhatsky wrote: > http://codereview.chromium.org/150219/diff/1/2 > File webkit/glue/devtools/js/inject_dispatch.js (right): > > http://codereview.chromium.org/150219/diff/1/2#newcode51 ...

11 years, 5 months ago (2009-07-02 10:27:57 UTC) #3

pfeldman

11 years, 5 months ago (2009-07-02 10:27:58 UTC) #4

http://codereview.chromium.org/150219/diff/1/2
File webkit/glue/devtools/js/inject_dispatch.js (right):

http://codereview.chromium.org/150219/diff/1/2#newcode51
Line 51: method == 'reset' ||
On 2009/07/02 10:27:13, Yury Semikhatsky wrote:
> wrong alignment

Done.

Expand Messages | Collapse Messages

Issue 150219: DevTools: Move InspectorController message filtering to the injected side. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages