Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: tools/valgrind/chrome_tests.py

Issue 150218: Disable IPCSyncChannelTest.* under Valgrind... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/valgrind/unit_tests.gtest_mac.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/chrome_tests.py
===================================================================
--- tools/valgrind/chrome_tests.py (revision 19805)
+++ tools/valgrind/chrome_tests.py (working copy)
@@ -188,15 +188,20 @@
'''
filters = []
for directory in self._data_dirs:
- filename = os.path.join(directory, name + ".gtest.txt")
- if os.path.exists(filename):
- logging.info("reading gtest filters from %s" % filename)
- f = open(filename, 'r')
- for line in f.readlines():
- if line.startswith("#") or line.startswith("//") or line.isspace():
- continue
- line = line.rstrip()
- filters.append(line)
+ platform_suffix = {'darwin': 'mac',
+ 'linux2': 'linux'}[sys.platform]
+ gtest_filter_files = [
+ os.path.join(directory, name + ".gtest.txt"),
+ os.path.join(directory, name + ".gtest_%s.txt" % platform_suffix)]
+ for filename in gtest_filter_files:
+ if os.path.exists(filename):
+ logging.info("reading gtest filters from %s" % filename)
+ f = open(filename, 'r')
+ for line in f.readlines():
+ if line.startswith("#") or line.startswith("//") or line.isspace():
+ continue
+ line = line.rstrip()
+ filters.append(line)
gtest_filter = self._options.gtest_filter
if len(filters):
if gtest_filter:
« no previous file with comments | « chrome/test/data/valgrind/unit_tests.gtest_mac.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698