Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 150218: Disable IPCSyncChannelTest.* under Valgrind... (Closed)

Created:
11 years, 5 months ago by Nirnimesh
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews_googlegroups.com, dank, Nirnimesh
Visibility:
Public.

Description

Disable IPCSyncChannelTest.* under Valgrind Times out too often under Valgrind on Mac Tracking bug: crbug.com/15817 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19846

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M chrome/test/data/valgrind/unit_tests.gtest.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
A chrome/test/data/valgrind/unit_tests.gtest_linux.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/valgrind/unit_tests.gtest_mac.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 1 chunk +14 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nirnimesh
11 years, 5 months ago (2009-07-02 10:08:37 UTC) #1
TVL
http://codereview.chromium.org/150218/diff/1/2 File chrome/test/data/valgrind/unit_tests.gtest.txt (right): http://codereview.chromium.org/150218/diff/1/2#newcode3 Line 3: IPCSyncChannelTest.* does this file apply to mac and ...
11 years, 5 months ago (2009-07-02 19:36:30 UTC) #2
Nirnimesh
http://codereview.chromium.org/150218/diff/1/2 File chrome/test/data/valgrind/unit_tests.gtest.txt (right): http://codereview.chromium.org/150218/diff/1/2#newcode3 Line 3: IPCSyncChannelTest.* On 2009/07/02 19:36:30, TVL wrote: > does ...
11 years, 5 months ago (2009-07-02 20:10:37 UTC) #3
TVL
11 years, 5 months ago (2009-07-02 20:13:46 UTC) #4
On 2009/07/02 20:10:37, Nirnimesh wrote:
> http://codereview.chromium.org/150218/diff/1/2
> File chrome/test/data/valgrind/unit_tests.gtest.txt (right):
> 
> http://codereview.chromium.org/150218/diff/1/2#newcode3
> Line 3: IPCSyncChannelTest.*
> On 2009/07/02 19:36:30, TVL wrote:
> > does this file apply to mac and linux?  does it timeout on linux also?  do
we
> > need to split the file?
> 
> Dan and I had decided that we'd continue using the same filter file until it
> became big enough, or until no one objected. :P
> 
> Broken down to _linux vs _mac files.

:)

thanks, since we were starting to prevents running on one platform because of
the other, it seemed like time for the slit.  :)

lgtm.

> 
> Thanks

Powered by Google App Engine
This is Rietveld 408576698