Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extensions_service.h

Issue 150213: Add a ExtensionBrowserTest base class (Closed)
Patch Set: added timeouts fixed other tests Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_startup_unittest.cc ('k') | chrome/browser/extensions/test_extension_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extensions_service.h
diff --git a/chrome/browser/extensions/extensions_service.h b/chrome/browser/extensions/extensions_service.h
index 4b28169ab8059a75896c41bf0c4c5b1912d625e4..5afa5475d6dadbf0884b79f4a58e31e594384764 100644
--- a/chrome/browser/extensions/extensions_service.h
+++ b/chrome/browser/extensions/extensions_service.h
@@ -129,7 +129,11 @@ class ExtensionsService
ExtensionInstallCallback* callback);
// Uninstalls the specified extension. Callers should only call this method
- // with extensions that exist.
+ // with extensions that exist. |external_uninstall| is a magical parameter
+ // that is only used to send information to ExtensionPrefs, which external
+ // callers should never set to true.
+ // TODO(aa): Remove |external_uninstall| -- this information should be passed
+ // to ExtensionPrefs some other way.
void UninstallExtension(const std::string& extension_id,
bool external_uninstall);
« no previous file with comments | « chrome/browser/extensions/extension_startup_unittest.cc ('k') | chrome/browser/extensions/test_extension_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698