Add a ExtensionBrowserTest base class

chrome/browser/extensions/extension_startup_unittest.cc

 #include <vector>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/browser/profile.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/notification_details.h"
 #include "chrome/common/notification_observer.h"
 #include "chrome/common/notification_registrar.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/notification_type.h"
 #include "chrome/test/in_process_browser_test.h"
 #include "chrome/test/ui_test_utils.h"
 #include "net/base/net_util.h"
 
-// This file contains high-level regression tests for the extensions system. The
-// goal here is not to test everything in depth, but to run the system as close
-// as possible end-to-end to find any gaps in test coverage in the lower-level
-// unit tests.
+// This file contains high-level startup tests for the extensions system. We've
+// had many silly bugs where command line flags did not get propagated correctly
+// into the services, so we didn't start correctly.
 
 class ExtensionStartupTestBase
   : public InProcessBrowserTest, public NotificationObserver {
  public:
   ExtensionStartupTestBase()
       : enable_extensions_(false), enable_user_scripts_(false) {
-    EnableDOMAutomation();
   }
 
  protected:
   // InProcessBrowserTest
   virtual void SetUpCommandLine(CommandLine* command_line) {
+    EnableDOMAutomation();
+
     FilePath profile_dir;
     PathService::Get(chrome::DIR_USER_DATA, &profile_dir);
     profile_dir = profile_dir.AppendASCII("Default");
     file_util::CreateDirectory(profile_dir);
 
     preferences_file_ = profile_dir.AppendASCII("Preferences");
     user_scripts_dir_ = profile_dir.AppendASCII("User Scripts");
     extensions_dir_ = profile_dir.AppendASCII("Extensions");
 
     if (enable_extensions_) {
@@ skipping 91 matching lines @@
   test_file = test_file.AppendASCII("extensions")
                        .AppendASCII("test_file.html");
 
   // Now we should be able to load a page affected by the content script and see
   // the effect.
   ui_test_utils::NavigateToURL(browser(), net::FilePathToFileURL(test_file));
 
   // Test that the content script ran.
   bool result = false;
   ui_test_utils::ExecuteJavaScriptAndExtractBool(
-      browser()->GetSelectedTabContents(), L"",
+      browser()->GetSelectedTabContents()->render_view_host(), L"",
       L"window.domAutomationController.send("
       L"document.defaultView.getComputedStyle(document.body, null)."
       L"getPropertyValue('background-color') == 'rgb(245, 245, 220)')",
       &result);
   EXPECT_TRUE(result);
 
   result = false;
   ui_test_utils::ExecuteJavaScriptAndExtractBool(
-      browser()->GetSelectedTabContents(), L"",
+      browser()->GetSelectedTabContents()->render_view_host(), L"",
       L"window.domAutomationController.send(document.title == 'Modified')",
       &result);
   EXPECT_TRUE(result);
-
-  // Load an extension page into the tab area to make sure it works.
-  result = false;
-  ui_test_utils::NavigateToURL(
-      browser(),
-      GURL("chrome-extension://behllobkkfkfnphdnhnkndlbkcpglgmj/page.html"));
-  ui_test_utils::ExecuteJavaScriptAndExtractBool(
-      browser()->GetSelectedTabContents(), L"", L"testTabsAPI()", &result);
-  EXPECT_TRUE(result);
-
-  // TODO(aa): Move the stuff in ExtensionBrowserTest here?
 }
 
 
 // ExtensionsStartupUserScriptTest
 // Tests that we can startup with --enable-user-scripts and run user sripts and
 // see them do basic things.
 
 class ExtensionsStartupUserScriptTest : public ExtensionStartupTestBase {
  public:
   ExtensionsStartupUserScriptTest() {
@@ skipping 18 matching lines @@
   test_file = test_file.AppendASCII("extensions")
                        .AppendASCII("test_file.html");
 
   // Now we should be able to load a page affected by the content script and see
   // the effect.
   ui_test_utils::NavigateToURL(browser(), net::FilePathToFileURL(test_file));
 
   // Test that the user script ran.
   bool result = false;
   ui_test_utils::ExecuteJavaScriptAndExtractBool(
-      browser()->GetSelectedTabContents(), L"",
+      browser()->GetSelectedTabContents()->render_view_host(), L"",
       L"window.domAutomationController.send(document.title == 'Modified')",
       &result);
   EXPECT_TRUE(result);
 }