Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 150208: Set the WebViewDelegate earlier during WebView creation to ensure that... (Closed)

Created:
11 years, 5 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw
Visibility:
Public.

Description

Set the WebViewDelegate earlier during WebView creation to ensure that DidCreateDataSource gets called when constructing the initial data source for the WebView's main frame. This ensures that the NavigationState associated with a WebDataSource can never be null. I went ahead and removed some of the null-checks that were added to avoid other related crashes. (To fix bug 15594, I really really didn't want to add another one of those null checks.) BUG=15594 TEST=partially covered by existing ui tests R=dglazkov

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -27 lines) Patch
M chrome/renderer/render_view.cc View 1 4 chunks +14 lines, -20 lines 0 comments Download
M webkit/glue/webview_impl.cc View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
darin (slow to review)
11 years, 5 months ago (2009-07-02 05:48:50 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698