Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 150207: Foundations for Print Preview and Setup... (Closed)

Created:
11 years, 5 months ago by Mohamed Mansour
Modified:
9 years, 6 months ago
Reviewers:
M-A Ruel, Sverrir
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Foundations for Print Preview and Setup Create the foundations of implementing a tab for printing should be in the form of: print:http://www.google.com I have followed similar approach as what has been done with view-source: and chrome-extension: BUG=173, 947 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19906

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -14 lines) Patch
M chrome/browser/autocomplete/autocomplete.cc View 1 2 3 4 5 6 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/child_process_security_policy.cc View 1 2 3 4 5 6 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.cc View 1 2 3 4 5 6 2 chunks +7 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/print_ui.h View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/print_ui.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/history/history.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Mohamed Mansour
Initial draft!
11 years, 5 months ago (2009-07-02 04:46:25 UTC) #1
Mohamed Mansour
Any remarks?
11 years, 5 months ago (2009-07-03 01:34:20 UTC) #2
M-A Ruel
Sorr for the delay! Looks good, can you fix the following errors? http://codereview.chromium.org/150207/diff/1006/1007 File chrome/browser/child_process_security_policy.cc ...
11 years, 5 months ago (2009-07-03 01:48:55 UTC) #3
Mohamed Mansour
Please re-review. My next step is to do a mockup for print preview and all ...
11 years, 5 months ago (2009-07-03 01:55:35 UTC) #4
Mohamed Mansour
Alright, grammar issues taken care of.
11 years, 5 months ago (2009-07-03 02:43:11 UTC) #5
M-A Ruel
lgtm with one nit http://codereview.chromium.org/150207/diff/3015/2031 File chrome/browser/child_process_security_policy.cc (right): http://codereview.chromium.org/150207/diff/3015/2031#newcode174 Line 174: // The view-source and ...
11 years, 5 months ago (2009-07-03 11:47:47 UTC) #6
Mohamed Mansour
done and committed! http://codereview.chromium.org/150207/diff/3015/2031 File chrome/browser/child_process_security_policy.cc (right): http://codereview.chromium.org/150207/diff/3015/2031#newcode174 Line 174: // The view-source and print ...
11 years, 5 months ago (2009-07-03 12:21:49 UTC) #7
Sverrir
11 years, 5 months ago (2009-07-03 14:59:05 UTC) #8
LGTM

Good work!

Powered by Google App Engine
This is Rietveld 408576698