Issue 150196: Fix leak on connection error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150196: Fix leak on connection error. (Closed)

Created:
11 years, 5 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix leak on connection error. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19792

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	net/socket/client_socket_pool_base.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eroman

11 years, 5 months ago (2009-07-02 00:44:39 UTC) #2

LGTM.

On the one hand I think it would be cleaner to defined
ConnectJob::ReleaseSocket() to return NULL in the case where the connect failed
-- right now the documentation leaves that case un-specified.

On the other hand, it may be more bug-prone to have each (future) ConnectJob
implementation remember about this contract.

Please do add some documentation to ReleaseSocket() about this behavior.

Expand Messages | Collapse Messages