Issue 150194: Fix performance issues with NNTP....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150194: Fix performance issues with NNTP.... (Closed)

Created:
11 years, 5 months ago by arv (Not doing code reviews)

Modified:
9 years, 3 months ago

Reviewers:
Glen Murphy, Miranda Callahan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix performance issues with NNTP. My tests show it as not as fast as the old NTP but it is a lot better than before these changes: Old NTP: 208 223 211 205 211 Average: 211.6 NNTP before this change: 732 718 718 713 Average: 720.25 NNTP with this change: 255 248 257 254 257 Average: 254.2 There is still room for improvements but this brings the NNTP perf closer to being acceptable. BUG=13362 TEST=Perf test at http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-cold/report.html?history=200 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19797

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -33 lines)			Patch
M	chrome/browser/resources/new_new_tab.css	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View	1 2	2 chunks	+12 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View	1 2	7 chunks	+22 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

11 years, 5 months ago (2009-07-02 00:58:17 UTC) #2

Great work.  LGTM.

On 2009/07/02 00:42:43, arv wrote:
>

Expand Messages | Collapse Messages