Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 150186: Move the NULLing out of WebViewImpl::delegate_ until after we close the page. (Closed)

Created:
11 years, 5 months ago by Matt Perry
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, DaveMoore
Visibility:
Public.

Description

Move the NULLing out of WebViewImpl::delegate_ until after we close the page. This allows us to receive notifications like when the V8 context is destroyed. BUG=12686 TEST=no

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webkit/glue/webview_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Matt Perry
There aren't many options as to where to move the NULLing of delegate_. I could ...
11 years, 5 months ago (2009-07-01 22:29:35 UTC) #1
darin (slow to review)
11 years, 5 months ago (2009-07-02 03:22:32 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698