Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm

Issue 150183: Call superclass's TearDown to avoid leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm (revision 19765)
+++ chrome/browser/cocoa/blocked_popup_container_controller_unittest.mm (working copy)
@@ -20,8 +20,6 @@
class BlockedPopupContainerControllerTest : public RenderViewHostTestHarness {
public:
- CocoaTestHelper cocoa_helper_; // Inits Cocoa, creates window, etc...
-
virtual void SetUp() {
RenderViewHostTestHarness::SetUp();
container_ = BlockedPopupContainer::Create(contents(), profile());
@@ -34,9 +32,10 @@
virtual void TearDown() {
// This will also signal the Cocoa controller to delete itself with a
- // Destroy() mesage to the bridge.
+ // Destroy() mesage to the bridge. It also clears out the association with
+ // |contents_|.
container_->Destroy();
- contents_->set_blocked_popup_container(NULL);
+ RenderViewHostTestHarness::TearDown();
}
TabContents* BuildTabContents() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698