Issue 150181: Adds some debugging code in hopes of tracking down a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150181: Adds some debugging code in hopes of tracking down a... (Closed)

Created:
11 years, 5 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds some debugging code in hopes of tracking down a crash. Specifically: . Adds a CHECK to IDMap that evaluates to true if adding NULL. The default isn't to do this check. . browser_shutdown CHECKs if the # RPHs changes while iterating through the RPHs. BUG=15615 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19779

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -3 lines)			Patch
M	base/id_map.h	View	4 chunks	+14 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_shutdown.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_process_host.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages