Issue 150168: Removed virtual behavior from Dictionaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150168: Removed virtual behavior from Dictionaries. (Closed)

Created:
11 years, 5 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Removed virtual behavior from Dictionaries. Committed: http://code.google.com/p/v8/source/detail?r=2324

Patch Set 1 #

Total comments: 5

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+588 lines, -501 lines)			Patch
M	src/bootstrapper.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/code-stubs.cc	View	2 chunks	+9 lines, -8 lines	0 comments	Download
M	src/factory.h	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	src/factory.cc	View	2 chunks	+15 lines, -6 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/heap.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/heap.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/objects.h	View	10 chunks	+215 lines, -121 lines	4 comments	Download
M	src/objects.cc	View	74 chunks	+284 lines, -303 lines	1 comment	Download
M	src/objects-debug.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	src/objects-inl.h	View	6 chunks	+20 lines, -22 lines	0 comments	Download
M	src/runtime.cc	View	6 chunks	+9 lines, -9 lines	0 comments	Download
M	src/stub-cache.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 5 months ago (2009-07-01 15:32:49 UTC) #2

LGTM

http://codereview.chromium.org/150168/diff/1/3
File src/objects.cc (right):

http://codereview.chromium.org/150168/diff/1/3#newcode2312
Line 2312: if (entry != StringDictionary::kNotFound) {
NumberDictionary::kNotFound

http://codereview.chromium.org/150168/diff/1/8
File src/objects.h (right):

http://codereview.chromium.org/150168/diff/1/8#newcode1882
Line 1882: //     static bool IsMatch(Key key, Object* other);
Short descriptions on each of these four methods would be nice.

http://codereview.chromium.org/150168/diff/1/8#newcode2209
Line 2209: // Copies enumerable keys to preallocated fixed array.
Add newline before comment.

http://codereview.chromium.org/150168/diff/1/8#newcode2236
Line 2236: // Type specific at put (default NONE attributes is used when
adding).
I would put a newline before the comment.

http://codereview.chromium.org/150168/diff/1/8#newcode2241
Line 2241: // Set an existing entry or add a new one if needed.
I would put a newline before the comment.

Expand Messages | Collapse Messages