Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 150162: Handle JavaScript accessors on the global object... (Closed)

Created:
11 years, 5 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Handle JavaScript accessors on the global object. With the new representation of the global object adding JavaScript accessors for a property after global inline caches was created for that property did not work property as the inline caches did not take the JavaScript accessor information (fixed array with two elements) that could be present in a global object property cell into account. This is now fixed by changing the map for a global object when a JavaScript accessor is defined on it. BUG=394 TEST=test\mjsunit\regress\regress-394.js Committed: http://code.google.com/p/v8/source/detail?r=2317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-394.js View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 5 months ago (2009-07-01 10:36:33 UTC) #1
Kasper Lund
11 years, 5 months ago (2009-07-01 11:16:25 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698