Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 150146: Add Reload and LoadData methods to WebFrame. (Closed)

Created:
11 years, 5 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw
Visibility:
Public.

Description

Add Reload and LoadData methods to WebFrame. LoadData replaces LoadAlternateHTMLString, changing types to WebKit API types and allowing for more flexibility (supports loading non-HTML data). LoadHTMLString is modified to support some optional parameters. Note: Since WebFrame is going to soon be part of the WebKit API, it is OK style-wise for it to use optional parameters. This patch also includes a change to remove the securityInfo property from WebURLRequest. I did this so that I could eliminate the need to pass a WebURLRequest to LoadData / LoadHTMLString. This also fixes a TODO of mine to eliminate this field on WebCore::ResourceRequest since securityInfo (SSL cert info) is really more of a response property. It was only part of the request as a hack to support certain error pages. I work around that by leveraging NavigationState in chrome/renderer. I added some templatized, implicit constructors to WebData for convenience. I plan to make similar changes to WebCString and WebString in a future CL. This CL is a incremental step toward moving ResourceFetcher out of WebFrame. BUG=15648 TEST=none R=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19742

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -218 lines) Patch
M chrome/renderer/navigation_state.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 6 chunks +24 lines, -31 lines 0 comments Download
M webkit/api/public/WebData.h View 1 4 chunks +22 lines, -3 lines 0 comments Download
M webkit/api/public/WebFrame.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/api/public/WebURLRequest.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/api/src/WebURLRequest.cpp View 1 1 chunk +0 lines, -10 lines 0 comments Download
M webkit/glue/bookmarklet_unittest.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M webkit/glue/cpp_bound_class_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/devtools/dom_agent_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/dom_serializer_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/glue_util.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M webkit/glue/glue_util.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/glue/webframe.h View 1 4 chunks +26 lines, -23 lines 0 comments Download
M webkit/glue/webframe_impl.h View 1 5 chunks +24 lines, -15 lines 0 comments Download
M webkit/glue/webframe_impl.cc View 1 9 chunks +88 lines, -104 lines 0 comments Download
M webkit/glue/webframe_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/webframeloaderclient_impl.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/plugin_tests.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 1 chunk +5 lines, -13 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
11 years, 5 months ago (2009-07-01 16:33:16 UTC) #1
dglazkov
11 years, 5 months ago (2009-07-01 17:09:27 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698