Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 150143: Scale function cleaned up white spaces and removed comments that are no longe... (Closed)

Created:
11 years, 5 months ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, brettw
Visibility:
Public.

Description

Scale function cleaned up white spaces and removed comments that are no longer applicable to this module. Removed openmp support, which is no longer necessary for high performance. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19971

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -86 lines) Patch
M media/base/yuv_convert.cc View 1 2 4 chunks +29 lines, -86 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fbarchard
cleaning up code/comments
11 years, 5 months ago (2009-06-30 23:56:55 UTC) #1
scherkus (not reviewing)
tiny nits on commenting http://codereview.chromium.org/150143/diff/1/2 File media/base/yuv_convert.cc (right): http://codereview.chromium.org/150143/diff/1/2#newcode23 Line 23: namespace media { nit: ...
11 years, 5 months ago (2009-07-02 00:25:30 UTC) #2
fbarchard
Done. http://codereview.chromium.org/150143/diff/1/2 File media/base/yuv_convert.cc (right): http://codereview.chromium.org/150143/diff/1/2#newcode23 Line 23: namespace media { On 2009/07/02 00:25:30, scherkus ...
11 years, 5 months ago (2009-07-06 07:41:39 UTC) #3
scherkus (not reviewing)
11 years, 5 months ago (2009-07-06 19:47:21 UTC) #4
tiny nits, but LGTM

http://codereview.chromium.org/150143/diff/2001/3001
File media/base/yuv_convert.cc (right):

http://codereview.chromium.org/150143/diff/2001/3001#newcode49
Line 49: // MMX used for FastConvertYUVToRGB32Row requires emms instruction.
nit: blank line before comments, unless it's first line in new scope block

http://codereview.chromium.org/150143/diff/2001/3001#newcode161
Line 161: // MMX used for FastConvertYUVToRGB32Row requires emms instruction.
nit: blank line before comments, unless it's first line in new scope block

Powered by Google App Engine
This is Rietveld 408576698