Issue 150141: Implement shortcut for finalizing a trial with all remaining probability...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150141: Implement shortcut for finalizing a trial with all remaining probability... (Closed)

Created:
11 years, 5 months ago by jar (doing other things)

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com, brettw

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implement shortcut for finalizing a trial with all remaining probability It is helpful when defining experiments to put all remaining probability on the final (often the "control" group), without having to keep a careful tally of assignments of probabilities. This CL implements that functionality. r=rvargas Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19696

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -7 lines)			Patch
M	base/field_trial.h	View	1 2	3 chunks	+5 lines, -3 lines	0 comments	Download
M	base/field_trial.cc	View	1 2	2 chunks	+8 lines, -3 lines	0 comments	Download
M	base/field_trial_unittest.cc	View	1 2	2 chunks	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

11 years, 5 months ago (2009-07-01 00:00:53 UTC) #2

LGTM. You may want to update the copyright notice.

Expand Messages | Collapse Messages