Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: views/widget/widget_win.h

Issue 150137: Fixes crash in ~WidgetGtk. This was caused by your change to no longer... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « views/widget/widget_gtk.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef VIEWS_WIDGET_WIDGET_WIN_H_ 5 #ifndef VIEWS_WIDGET_WIDGET_WIN_H_
6 #define VIEWS_WIDGET_WIDGET_WIN_H_ 6 #define VIEWS_WIDGET_WIDGET_WIN_H_
7 7
8 #include <atlbase.h> 8 #include <atlbase.h>
9 #include <atlapp.h> 9 #include <atlapp.h>
10 #include <atlcrack.h> 10 #include <atlcrack.h>
(...skipping 498 matching lines...) Expand 10 before | Expand all | Expand 10 after
509 509
510 // Creates the RootView to be used within this Widget. Can be overridden to 510 // Creates the RootView to be used within this Widget. Can be overridden to
511 // create specialized RootView implementations. 511 // create specialized RootView implementations.
512 virtual RootView* CreateRootView(); 512 virtual RootView* CreateRootView();
513 513
514 // Returns true if this WidgetWin is opaque. 514 // Returns true if this WidgetWin is opaque.
515 bool opaque() const { return opaque_; } 515 bool opaque() const { return opaque_; }
516 516
517 // The TooltipManager. 517 // The TooltipManager.
518 // WARNING: RootView's destructor calls into the TooltipManager. As such, this 518 // WARNING: RootView's destructor calls into the TooltipManager. As such, this
519 // must be destroyed AFTER root_view_. This really only matters during 519 // must be destroyed AFTER root_view_.
520 // WM_SESSIONEND, as normally the hwnd is destroyed which tiggers unsetting
521 // the widget in the RootView so that RootView's destructor doesn't call into
522 // the TooltipManager.
523 scoped_ptr<TooltipManagerWin> tooltip_manager_; 520 scoped_ptr<TooltipManagerWin> tooltip_manager_;
524 521
525 // The focus manager keeping track of focus for this Widget and any of its 522 // The focus manager keeping track of focus for this Widget and any of its
526 // children. NULL for non top-level widgets. 523 // children. NULL for non top-level widgets.
527 // WARNING: RootView's destructor calls into the FocusManager. As such, this 524 // WARNING: RootView's destructor calls into the FocusManager. As such, this
528 // must be destroyed AFTER root_view_. 525 // must be destroyed AFTER root_view_.
529 scoped_ptr<FocusManager> focus_manager_; 526 scoped_ptr<FocusManager> focus_manager_;
530 527
531 // The root of the View hierarchy attached to this window. 528 // The root of the View hierarchy attached to this window.
532 // WARNING: see warning in tooltip_manager_ for ordering dependencies with 529 // WARNING: see warning in tooltip_manager_ for ordering dependencies with
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
642 639
643 scoped_ptr<DefaultThemeProvider> default_theme_provider_; 640 scoped_ptr<DefaultThemeProvider> default_theme_provider_;
644 641
645 // Our hwnd. 642 // Our hwnd.
646 HWND hwnd_; 643 HWND hwnd_;
647 }; 644 };
648 645
649 } // namespace views 646 } // namespace views
650 647
651 #endif // #ifndef VIEWS_WIDGET_WIDGET_WIN_H_ 648 #endif // #ifndef VIEWS_WIDGET_WIDGET_WIN_H_
OLDNEW
« no previous file with comments | « views/widget/widget_gtk.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698