Issue 150137: Fixes crash in ~WidgetGtk. This was caused by your change to no longer...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150137: Fixes crash in ~WidgetGtk. This was caused by your change to no longer... (Closed)

Created:
11 years, 5 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fixes crash in ~WidgetGtk. This was caused by your change to no longer set RootView::widget_ = NULL in RootView::OnWidgetDestroyed. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19684

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	views/widget/widget_gtk.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	views/widget/widget_win.h	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM

Sorry for the regression.