Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Issue 150122: Fix to allow browser close after download initiated from chrome:// url (Closed)

Created:
11 years, 5 months ago by rafaelw
Modified:
9 years, 7 months ago
Reviewers:
Charlie Reis, brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix to allow browser close after download initiated from chrome:// url. R=brettw BUG=12745 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19752

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -1 line) Patch
M chrome/browser/renderer_host/render_view_host_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_manager.cc View 3 chunks +12 lines, -1 line 1 comment Download
M chrome/browser/renderer_host/render_view_host_manager_browsertest.cc View 2 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rafaelw
Charles, If you can review this as well, I'd appreciate it. Note your comment in ...
11 years, 5 months ago (2009-06-30 19:09:06 UTC) #1
Charlie Reis
There's been a lot of refactoring since that comment in RendererAbortedProvisionalLoad, so it's possible that ...
11 years, 5 months ago (2009-06-30 19:59:25 UTC) #2
brettw
11 years, 5 months ago (2009-07-01 15:25:22 UTC) #3
LGTM

http://codereview.chromium.org/150122/diff/1/2
File chrome/browser/renderer_host/render_view_host_manager.cc (right):

http://codereview.chromium.org/150122/diff/1/2#newcode222
Line 222: if (pending_render_view_host_) {
Don't add {} here since you didn't below (and the rest of the file doesn't
either).

Powered by Google App Engine
This is Rietveld 408576698