Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 150120: Add layout support for invisible SingleSplitView children. (Closed)

Created:
11 years, 5 months ago by pfeldman
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Add layout support for invisible SingleSplitView children. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19737

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M views/controls/single_split_view.cc View 1 2 chunks +25 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pfeldman
This CL makes a child view occupy all the space available if the other child ...
11 years, 5 months ago (2009-06-30 18:33:30 UTC) #1
sky
http://codereview.chromium.org/150120/diff/1/2 File views/controls/single_split_view.cc (right): http://codereview.chromium.org/150120/diff/1/2#newcode149 Line 149: if (GetChildViewCount() < 2) You need to update ...
11 years, 5 months ago (2009-06-30 18:52:42 UTC) #2
pfeldman
On 2009/06/30 18:52:42, sky wrote: > http://codereview.chromium.org/150120/diff/1/2 > File views/controls/single_split_view.cc (right): > > http://codereview.chromium.org/150120/diff/1/2#newcode149 > ...
11 years, 5 months ago (2009-07-01 12:38:33 UTC) #3
sky
11 years, 5 months ago (2009-07-01 15:28:31 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698