Issue 150109: make FilePath:IsParent use case-insensitive compare for drive letters on windows

Issue 150109: make FilePath:IsParent use case-insensitive compare for drive letters on windows (Closed)

Created:
11 years, 5 months ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews, Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

make FilePath:IsParent use case-insensitive compare for drive letters on windows R=erikkay BUG=15659 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19694

Patch Set 4 : one more #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -7 lines)			Patch
M	base/file_path.h	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	base/file_path.cc	View	1 2	3 chunks	+52 lines, -0 lines	0 comments	Download
M	base/file_path_unittest.cc	View	1 2 3	3 chunks	+70 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

http://codereview.chromium.org/150109/diff/1/2 File base/file_path.cc (right): http://codereview.chromium.org/150109/diff/1/2#newcode139 Line 139: #if defined(OS_WIN) Should this be defined(FILE_PATH_USES_DRIVE_LETTERS)?

11 years, 5 months ago (2009-06-30 16:45:27 UTC) #2

Erik does not do reviews

In addition to Avi's comment, can you add the same test to the equality code?

11 years, 5 months ago (2009-06-30 16:52:36 UTC) #3

rafaelw

Made equality and inequality drive-letter-case-insensitive. Added equality/inequality unittests. http://codereview.chromium.org/150109/diff/1/2 File base/file_path.cc (right): http://codereview.chromium.org/150109/diff/1/2#newcode139 Line 139: ...

11 years, 5 months ago (2009-06-30 22:12:14 UTC) #4

Erik does not do reviews

LGTM with a couple of nits Add a comment to the three methods in the ...

11 years, 5 months ago (2009-06-30 22:20:58 UTC) #5

rafaelw

11 years, 5 months ago (2009-06-30 22:37:52 UTC) #6

http://codereview.chromium.org/150109/diff/8/1003
File base/file_path.cc (right):

http://codereview.chromium.org/150109/diff/8/1003#newcode67
Line 67: return a == b;
On 2009/06/30 22:20:58, Erik Kay wrote:
> I'd make the whole method surrounded by the #ifdef since it only gets called
> from that #ifdef.

Done.

http://codereview.chromium.org/150109/diff/8/1005
File base/file_path_unittest.cc (right):

http://codereview.chromium.org/150109/diff/8/1005#newcode512
Line 512: #if defined(FILE_PATH_USES_WIN_SEPARATORS)
On 2009/06/30 22:20:58, Erik Kay wrote:
> add some drive letter tests in here too?

Done.

Expand Messages | Collapse Messages