Issue 150102: Fix the tree. It looks like the previous change (19561)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150102: Fix the tree. It looks like the previous change (19561)... (Closed)

Created:
11 years, 5 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com, kuchhal

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix the tree. It looks like the previous change (19561) did not work as expected, since most of the windows machines are red trying to load dwmapi.dll, which should be in the delay load list. I'm reverting part of this change. TBR:bradnelson Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19581

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -17 lines)			Patch
	M	build/common.gypi	View		4 chunks	+7 lines, -16 lines	0 comments	Download
	M	chrome/installer/mini_installer.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

11 years, 5 months ago (2009-06-30 16:48:38 UTC) #2

LGTM++

Sorry I thought it was green and wandered off.
Thanks!

Expand Messages | Collapse Messages