Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 150101: Tweaks to global object inline cache code (Closed)

Created:
11 years, 5 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Tweaks to global object inline cache code. Remove the check for deleted properties in the global load inline cache if the property is known to be read only. Propegate the in loop flag for the global call inline cache. Changed the propagation of the code flags in the call stub compiler to compute these the same way for all types of call stubs and assert that the flags for the generated code is the same as those used for the cache lookup. Addressed a few comments from previous review in test-api.cc. Committed: http://code.google.com/p/v8/source/detail?r=2308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -47 lines) Patch
M src/arm/stub-cache-arm.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M src/disassembler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M src/ic.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/stub-cache.h View 4 chunks +9 lines, -7 lines 0 comments Download
M src/stub-cache.cc View 7 chunks +16 lines, -10 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 5 months ago (2009-06-30 14:00:03 UTC) #1
Kasper Lund
11 years, 5 months ago (2009-06-30 14:03:30 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698