Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: chrome/browser/dom_ui/chrome_url_data_manager.cc

Issue 15010: Implement extension:// protocol. (Closed)
Patch Set: add missing unit test Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_main.cc ('k') | chrome/browser/extensions/extension.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/chrome_url_data_manager.cc
diff --git a/chrome/browser/dom_ui/chrome_url_data_manager.cc b/chrome/browser/dom_ui/chrome_url_data_manager.cc
index 623ad8d43ab6aae173046c182e63ef498e20c898..940ed683d976f450ee81b39c896a3e54d1ca4067 100644
--- a/chrome/browser/dom_ui/chrome_url_data_manager.cc
+++ b/chrome/browser/dom_ui/chrome_url_data_manager.cc
@@ -83,7 +83,7 @@ class URLRequestChromeJob : public URLRequestJob {
// URLRequestChromeFileJob is a URLRequestJob that acts like a file:// URL
class URLRequestChromeFileJob : public URLRequestFileJob {
public:
- URLRequestChromeFileJob(URLRequest* request, const std::wstring& path);
+ URLRequestChromeFileJob(URLRequest* request, const FilePath& path);
virtual ~URLRequestChromeFileJob();
private:
@@ -244,7 +244,8 @@ URLRequestJob* ChromeURLDataManager::Factory(URLRequest* request,
// Try first with a file handler
std::wstring path;
if (ChromeURLDataManager::URLToFilePath(request->url(), &path))
- return new URLRequestChromeFileJob(request, path);
+ return new URLRequestChromeFileJob(request,
+ FilePath::FromWStringHack(path));
// Fall back to using a custom handler
return new URLRequestChromeJob(request);
@@ -329,10 +330,8 @@ void URLRequestChromeJob::StartAsync() {
}
URLRequestChromeFileJob::URLRequestChromeFileJob(URLRequest* request,
- const std::wstring& path)
- : URLRequestFileJob(request) {
- // set URLRequestFileJob::file_path_
- this->file_path_ = FilePath::FromWStringHack(path);
+ const FilePath& path)
+ : URLRequestFileJob(request, path) {
}
URLRequestChromeFileJob::~URLRequestChromeFileJob() { }
« no previous file with comments | « chrome/browser/browser_main.cc ('k') | chrome/browser/extensions/extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698