Fixing EffectTest.LogOpenGLCalls and cleaning up a line in DrawPassTest.

Fixing EffectTest.LogOpenGLCalls and cleaning up a line in DrawPassTest.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19749

[Antoine Labour, 2009-06-30 02:16:42]

http://codereview.chromium.org/150089/diff/1/2
File core/cross/command_buffer/buffer_cb.cc (right):

http://codereview.chromium.org/150089/diff/1/2#newcode61
Line 61: if (renderer_->vertex_buffer_ids().InUse(resource_id_)) {
I suggest resetting resource_id_ to command_buffer::kInvalidResource when
destroying, and testing that it is not command_buffer::kInvalidResource here.
Aside the fact that it's marginally faster, it's also easier to debug.

[apatrick, 2009-06-30 15:50:55]

LGTM

[rlp, 2009-07-01 00:13:05]

http://codereview.chromium.org/150089/diff/1/2
File core/cross/command_buffer/buffer_cb.cc (right):

http://codereview.chromium.org/150089/diff/1/2#newcode61
Line 61: if (renderer_->vertex_buffer_ids().InUse(resource_id_)) {
On 2009/06/30 02:16:42, Antoine Labour wrote:
> I suggest resetting resource_id_ to command_buffer::kInvalidResource when
> destroying, and testing that it is not command_buffer::kInvalidResource here.
> Aside the fact that it's marginally faster, it's also easier to debug.

Done.

[Antoine Labour, 2009-07-01 01:13:04]

LGTM