Issue 150078: GTK custom frame: Don't show the border when maximized. Enlarge the close but...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150078: GTK custom frame: Don't show the border when maximized. Enlarge the close but... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK custom frame: Don't show the border when maximized. Enlarge the close button's clickable area when maximized. BUG= http://crbug.com/14646 and http://crbug.com/15628 TEST=maximize, turn on custom frame. The top right most pixel on the screen should be clickable and should close the window. There should be no border around the web contents. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19567

Patch Set 1 #

Patch Set 2 : now with bidi support #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -9 lines)			Patch
M	chrome/browser/gtk/browser_titlebar.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/browser_titlebar.cc	View	3 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	4 chunks	+4 lines, -8 lines	0 comments	Download
M	chrome/browser/gtk/custom_button.cc	View	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

On 2009/06/30 00:11:20, tony wrote: > LGTM I noticed there was a bidi bug, can ...

11 years, 5 months ago (2009-06-30 00:13:38 UTC) #3

Nice catch, LGTM.

Expand Messages | Collapse Messages