|
|
Move RenderViewHostManager back to tab_contents. Moving it to renderer_host
was a bad idea because of its significant dependencies on NavigationController
and NavigationEntry. I'm trying to make renderer_host not depend on tab_contents
at all.
Remove the dependency on TabContents pointers for notifications from the
ResourceDispatcherHost. Instead of having the broadcast code in the
ResourceDispatcherHost, I made it call a RenderViewHostDelegate callback. Then
TabContents implements the notification, so that it's really from the
TabContents.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19909
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+98 lines, -1198 lines) |
Patch |
 |
M |
chrome/browser/renderer_host/render_view_host_delegate.h
|
View
|
3
4
5
6
|
2 chunks |
+20 lines, -0 lines |
0 comments
|
Download
|
|
D |
chrome/browser/renderer_host/render_view_host_manager.h
|
View
|
1
2
3
4
5
6
|
1 chunk |
+0 lines, -267 lines |
0 comments
|
Download
|
|
D |
chrome/browser/renderer_host/render_view_host_manager.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+0 lines, -612 lines |
0 comments
|
Download
|
|
D |
chrome/browser/renderer_host/render_view_host_manager_unittest.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+0 lines, -250 lines |
0 comments
|
Download
|
|
M |
chrome/browser/renderer_host/resource_dispatcher_host.cc
|
View
|
3
4
5
6
|
6 chunks |
+50 lines, -54 lines |
0 comments
|
Download
|
|
A + |
chrome/browser/tab_contents/render_view_host_manager.h
|
View
|
1
2
3
4
5
6
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
A + |
chrome/browser/tab_contents/render_view_host_manager.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
A + |
chrome/browser/tab_contents/render_view_host_manager_unittest.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/tab_contents/tab_contents.h
|
View
|
1
2
3
4
5
6
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/tab_contents/tab_contents.cc
|
View
|
3
4
5
6
|
3 chunks |
+16 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/chrome.gyp
|
View
|
1
2
3
4
5
6
|
4 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/common/notification_type.h
|
View
|
3
4
5
6
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|
Chromium Code Reviews
Issue
150069:
Move RenderViewHostManager back to tab_contents. Moving it to renderer_host... (Closed)
