Issue 150045: Learned that mini_installer's linker settings cannot actually be shared...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150045: Learned that mini_installer's linker settings cannot actually be shared... (Closed)

Created:
11 years, 5 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
sgk

CC:
chromium-reviews_googlegroups.com, kuchhal

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Learned that mini_installer's linker settings cannot actually be shared by everyone else. Separated mini_installer into its own gyp file and isolated it from several common settings. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19561

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -152 lines)			Patch
M	build/common.gypi	View		5 chunks	+17 lines, -8 lines	1 comment	Download
M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/installer.gyp	View		1 chunk	+0 lines, -144 lines	0 comments	Download
A	chrome/installer/mini_installer.gyp	View	2	1 chunk	+180 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sgk

11 years, 5 months ago (2009-07-06 16:25:07 UTC) #2

http://codereview.chromium.org/150045/diff/9/1007
File build/common.gypi (right):

http://codereview.chromium.org/150045/diff/9/1007#newcode541
Line 541: '/safeseh /dynamicbase /ignore:4199 /ignore:4221 /nxcompat',
The section above that it looks like this is intended to replace sets
/safeseh:NO and /dynamicbase:NO.  Is the removal of ':NO' intentional?

Expand Messages | Collapse Messages