Issue 150026: - Add a "#error Unsupported target architecture." where needed. A chain of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150026: - Add a "#error Unsupported target architecture." where needed. A chain of... (Closed)

Created:
11 years, 5 months ago by iposva

Modified:
9 years, 3 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Add a "#error Unsupported target architecture." where needed. A chain of platform dependent ifdefs is useless if it does not include an error like this. You will end up searching for the failure in all the wrong places. Committed: http://code.google.com/p/v8/source/detail?r=2298

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -1 line)			Patch
M	src/codegen.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/execution.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/frames-inl.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/jsregexp.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/macro-assembler.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/platform-macos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/virtual-frame.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks for doing this.

Expand Messages | Collapse Messages