Issue 150021: Replaced DateFromTime and isNaN with macro calls in date code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150021: Replaced DateFromTime and isNaN with macro calls in date code. (Closed)

Created:
11 years, 5 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Replaced DateFromTime and isNaN with macro calls in date code. Committed: http://code.google.com/p/v8/source/detail?r=2294

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -77 lines)			Patch
	M	src/date-delay.js	View		27 chunks	+80 lines, -77 lines	1 comment	Download
	M	src/macros.py	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 5 months ago (2009-06-29 12:03:07 UTC) #3

http://codereview.chromium.org/150021/diff/1/3
File src/date-delay.js (right):

http://codereview.chromium.org/150021/diff/1/3#newcode44
Line 44: function ThrowTypeError() {
How about calling this something with Date in the name? It's pretty specific to
the date implementation.

Expand Messages | Collapse Messages