Issue 150007: X64: Fix error in running handlers, disable TakeValue optimization for count ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150007: X64: Fix error in running handlers, disable TakeValue optimization for count ... (Closed)

Created:
11 years, 6 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Fix error in running handlers, disable TakeValue optimization for count operators. Committed: http://code.google.com/p/v8/source/detail?r=2288

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	src/x64/codegen-x64.cc	View	1 2	4 chunks	+5 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

11 years, 5 months ago (2009-06-29 06:53:56 UTC) #2

LGTM

http://codereview.chromium.org/150007/diff/7/1002
File src/x64/codegen-x64.cc (left):

http://codereview.chromium.org/150007/diff/7/1002#oldcode2304
Line 2304: if (false && literal != NULL || (right_var != NULL && right_var !=
var)) {
Ack, yes, bad grouping.

Expand Messages | Collapse Messages