Issue 149798: Added inline caching for calls to a field to X64. Changed a use of Array::kH...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149798: Added inline caching for calls to a field to X64. Changed a use of Array::kH... (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added inline caching for calls to a field to X64. Changed a use of Array::kHeaderSize to FixedArray::kHeaderSize on all platforms. Committed: http://code.google.com/p/v8/source/detail?r=2496

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -17 lines)			Patch
M	src/arm/stub-cache-arm.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	2 chunks	+85 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 5 months ago (2009-07-17 08:22:03 UTC) #2

LGTM.

http://codereview.chromium.org/149798/diff/1/3
File src/x64/stub-cache-x64.cc (right):

http://codereview.chromium.org/149798/diff/1/3#newcode185
Line 185: // rsp[(argc + 1) * 8] argument 0 = reciever
i before e except after c: reciever -> receiver

Expand Messages | Collapse Messages