Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 149795: Add a command line argument to disable message boxes. This is useful to... (Closed)

Created:
11 years, 5 months ago by abarth-chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, brettw
Visibility:
Public.

Description

Add a command line argument to disable message boxes. This is useful to extension developers who want to package extensions as part of a build script and aren't there to click the message box. R=aa,jackson BUG=14732 TEST=Pack an extension with the --no-message-box flag and notice that there is no message box. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M app/win_util.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M base/base_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/base_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
11 years, 5 months ago (2009-07-17 05:15:15 UTC) #1
Aaron Boodman
Only thing with this is that it relies on using MsgBox (on windows) to silence ...
11 years, 5 months ago (2009-07-17 05:24:39 UTC) #2
abarth-chromium
Sure, we could do that. How do the other platforms notify the user on success ...
11 years, 5 months ago (2009-07-17 05:45:11 UTC) #3
jackson_old
I tried it and it works as advertised. LGTM On 2009/07/17 05:45:11, abarth wrote: > ...
11 years, 5 months ago (2009-07-17 06:10:13 UTC) #4
tony
On a side note, should we try to reuse the existing --noerrdialogs flag in base_switches? ...
11 years, 5 months ago (2009-07-17 20:45:09 UTC) #5
abarth-chromium
11 years, 5 months ago (2009-07-17 22:03:29 UTC) #6
On 2009/07/17 20:45:09, tony wrote:
> On a side note, should we try to reuse the existing --noerrdialogs flag in
> base_switches?  These two flags sound very similar to me.

Yeah, it seems like we should merge these two.  The particular use case for this
change was a success dialog, so that flag didn't quite seem right.  Maybe a less
judgmental name would work for both?

Powered by Google App Engine
This is Rietveld 408576698