Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 149792: Enable DOM_STORAGE in our build. (Closed)

Created:
11 years, 5 months ago by jorlow
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)
Visibility:
Public.

Description

Enable DOM_STORAGE in our build. Put LocalStorage and SessionStorage behind their own flags. Add the beginnings of StorageNamespaceProxy since it implements WebCore::StorageNamespace::____StorageNamespace and we'd get link errors otherwise. --enable-local-storage and --enable-session-storage are the new flags. If you enable them and try to use DOM Storage, Chromium will crash. BUG=4360 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21059

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -11 lines) Patch
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +5 lines, -1 line 0 comments Download
A webkit/api/src/StorageNamespaceProxy.h View 1 chunk +37 lines, -0 lines 2 comments Download
A webkit/api/src/StorageNamespaceProxy.cpp View 1 chunk +47 lines, -0 lines 2 comments Download
M webkit/glue/webpreferences.h View 2 chunks +5 lines, -1 line 0 comments Download
M webkit/glue/webview_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/webkit.gyp View 5 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jorlow
This is ready for review.
11 years, 5 months ago (2009-07-17 04:49:37 UTC) #1
darin (slow to review)
LGTM http://codereview.chromium.org/149792/diff/1/5 File webkit/api/src/StorageNamespaceProxy.cpp (right): http://codereview.chromium.org/149792/diff/1/5#newcode35 Line 35: ASSERT(false); this is fine, but there is ...
11 years, 5 months ago (2009-07-17 06:15:48 UTC) #2
jorlow
11 years, 5 months ago (2009-07-18 00:47:23 UTC) #3
Going to land once Eric rolls the deps.

http://codereview.chromium.org/149792/diff/1/5
File webkit/api/src/StorageNamespaceProxy.cpp (right):

http://codereview.chromium.org/149792/diff/1/5#newcode35
Line 35: ASSERT(false);
On 2009/07/17 06:15:48, darin wrote:
> this is fine, but there is also ASSERT_NOT_REACHED() that you can use in
WebKit
> land.

Done.

http://codereview.chromium.org/149792/diff/1/6
File webkit/api/src/StorageNamespaceProxy.h (right):

http://codereview.chromium.org/149792/diff/1/6#newcode2
Line 2: * Copyright (C) 2008 Apple Inc. All Rights Reserved.
On 2009/07/17 06:15:48, darin wrote:
> Shouldn't this be copyright Google?  and 2009?

Done.

Powered by Google App Engine
This is Rietveld 408576698