Use base::Time::Exploded instead of struct tm in...

Use base::Time::Exploded instead of struct tm in
ftp_directory_parser.{h,cc}.

The patch is contributed by Ibrar Ahmed <ibrar.ahmad@gmail.com>;.

Original review URL: http://codereview.chromium.org/126096

R=wtc
BUG=http://crbug.com/4965
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21003

[wtc, 2009-07-16 23:28:49]

Ibrar, please review the diffs between Patch Set 1 and
Patch Set 2, which are my edits of your original CL.

I compared our files with the Mozilla upstream carefully,
so we can understand the intent of the code.  I found some
bugs in the Mozilla upsteam code in their handling of
two-digit years, and will submit a patch to Mozilla.

http://codereview.chromium.org/149772/diff/1002/11
File net/ftp/ftp_directory_parser.cc (right):

http://codereview.chromium.org/149772/diff/1002/11#newcode692
Line 692: result->fe_time.month = StringToInt(tokens[0] + 0);
Note on the following change:

We should compare result->fe_time.month with 0 rather
than 1.  In fact, I think that test should probably be
  if (result->fe_time.month >=1 &&
      result->fe_time.month <= 12)

We don't need to do result->fe_time.month-- because
result->fe_time.month is already 1-based.

I copied the += 2000 and += 1900 code from Mozilla upstream.
I believe your code is correct (which assumes the year is
two digits), but let's follow the upstream.

http://codereview.chromium.org/149772/diff/1002/10
File net/ftp/ftp_directory_parser.h (right):

http://codereview.chromium.org/149772/diff/1002/10#newcode39
Line 39: 
I made the following edits in this file.

1. I changed the type of now_tm_valid to 'int' to be
consistent with the 'int parsed_one' member.

2. I moved the fe_time member up to match the ordering
in the original Mozilla file.

[wtc, 2009-07-17 05:10:02]

I submitted my patch to Mozilla in
https://bugzilla.mozilla.org/show_bug.cgi?id=504726