Issue 149717: [Mac] Refactor location-bar autocomplete cell classes.

Issue 149717: [Mac] Refactor location-bar autocomplete cell classes. (Closed)

Created:
11 years, 5 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Refactor location-bar autocomplete cell classes. LocationBarCell -> AutocompleteTextFieldCell. LocationBarFieldEditor -> AutocompleteTextFieldEditor. AutocompleteTextField added as placeholder for future work (hints and keyword search).

Patch Set 1 #

Total comments: 1

Patch Set 2 : jrg comment #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+419 lines, -285 lines)			Patch
M	chrome/app/nibs/en.lproj/Toolbar.xib	View		6 chunks	+20 lines, -10 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.h	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View		3 chunks	+9 lines, -4 lines	0 comments	Download
A	chrome/browser/cocoa/autocomplete_text_field.h	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/autocomplete_text_field.mm	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/autocomplete_text_field_cell.h	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/autocomplete_text_field_cell.mm	View		1 chunk	+80 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm	View		1 chunk	+48 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/autocomplete_text_field_editor.h	View		1 chunk	+17 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/autocomplete_text_field_editor.mm	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm	View		1 chunk	+88 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/autocomplete_text_field_unittest.mm	View		1 chunk	+46 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar_cell.h	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar_cell.mm	View		1 chunk	+0 lines, -80 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar_cell_unittest.mm	View		1 chunk	+0 lines, -42 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar_fieldeditor_unittest.mm	View		1 chunk	+0 lines, -88 lines	0 comments	Download
M	chrome/browser/cocoa/location_bar_view_mac.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/location_bar_view_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller.h	View		4 chunks	+4 lines, -11 lines	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller.mm	View		3 chunks	+8 lines, -29 lines	0 comments	Download
M	chrome/chrome.gyp	View		4 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

I tried not to make egregious changes in this CL, so for the renamed items, ...

11 years, 5 months ago (2009-07-15 23:17:27 UTC) #1

John Grabowski

11 years, 5 months ago (2009-07-16 00:21:39 UTC) #2

LGTM
Scanned briefly since this is a rename change only.

http://codereview.chromium.org/149717/diff/1/5
File chrome/browser/cocoa/autocomplete_text_field.h (right):

http://codereview.chromium.org/149717/diff/1/5#newcode10
Line 10: // NOTE(shess): This class will add decorations to support keyword
NOTE(shess) --> TODO(shess)

Expand Messages | Collapse Messages