Issue 149694: Only register for popup menu notifications from our popup cell, not all of th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149694: Only register for popup menu notifications from our popup cell, not all of th... (Closed)

Created:
11 years, 5 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
Paul Godavari

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Only register for popup menu notifications from our popup cell, not all of them. BUG=16299 TEST=get a blocked popup, go to a site that has html selects. the popup menus should both work correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20768

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/cocoa/blocked_popup_container_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages