Print only the focused frame. This makes more sense than trying to print all...

chrome/renderer/render_view.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_view.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 433 matching lines @@
   if (!CaptureThumbnail(webview(), kThumbnailWidth, kThumbnailHeight,
                         &thumbnail, &score))
     return;
 
   // send the thumbnail message to the browser process
   Send(new ViewHostMsg_Thumbnail(routing_id_, url, score, thumbnail));
 }
 
 void RenderView::OnPrintPages() {
   DCHECK(webview());
-  if (webview())
-    Print(webview()->GetMainFrame(), false);
+  if (webview()) {
+    // If the user has selected text in the currently focused frame we print
+    // only that frame (this makes print selection work for multiple frames).
+    if (webview()->GetFocusedFrame()->HasSelection())
+      Print(webview()->GetFocusedFrame(), false);
+    else
+      Print(webview()->GetMainFrame(), false);
+  }
 }
 
 void RenderView::OnPrintingDone(int document_cookie, bool success) {
   // Ignoring document cookie here since only one print job can be outstanding
   // per renderer and document_cookie is 0 when printing is successful.
   DCHECK(print_helper_.get());
   if (print_helper_.get() != NULL) {
     print_helper_->DidFinishPrinting(success);
   }
 }
@@ skipping 1836 matching lines @@
   // Save the updated IME status and mark the input focus has been updated.
   // The IME status is to be sent to a browser process next time when
   // the input caret is rendered.
   if (!ime_control_busy_) {
     ime_control_updated_ = true;
     ime_control_new_state_ = enabled;
   }
 }
 
 void RenderView::ScriptedPrint(WebFrame* frame) {
-  Print(frame, true);
+  DCHECK(webview());
+  if (webview()) {
+    // Print the full page - not just the frame the javascript is running from.
+    Print(webview()->GetMainFrame(), true);

[darin (slow to review), 2009/09/16 16:28:50]

this seems like it is introducing a potential web compat bug.  why was this
change made?  if i use window.print(), other browsers will print the frame
corresponding to window.  it seems like this could matter to some web apps that
use window.print().  how do we know that this change is a good thing?

neither the description of this CL nor the comment above provide the
justification for this change.  can you please enlighten me? :-)

[M-A Ruel, 2009/09/16 16:35:03]

That is interesting, I didn't realize that change. I'll create a separate
change.

+  }
 }
 
 void RenderView::UserMetricsRecordAction(const std::wstring& action) {
   Send(new ViewHostMsg_UserMetricsRecordAction(routing_id_, action));
 }
 
 void RenderView::DnsPrefetch(const std::vector<std::string>& host_names) {
   Send(new ViewHostMsg_DnsPrefetch(host_names));
 }
 
@@ skipping 725 matching lines @@
     Send(new ViewHostMsg_PasswordFormsSeen(routing_id_, password_forms));
 }
 
 void RenderView::Print(WebFrame* frame, bool script_initiated) {
   DCHECK(frame);
   if (print_helper_.get() == NULL) {
     print_helper_.reset(new PrintWebViewHelper(this));
   }
   print_helper_->Print(frame, script_initiated);
 }