Various minor extension fixes

chrome/browser/profile.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profile.h"
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
@@ skipping 550 matching lines @@
       script_dir);
   extensions_service_ = new ExtensionsService(
       this,
       CommandLine::ForCurrentProcess(),
       GetPrefs(),
       GetPath().AppendASCII(ExtensionsService::kInstallDirectoryName),
       MessageLoop::current(),
       g_browser_process->file_thread()->message_loop());
 
   extensions_service_->Init();
+
+  // Load any extensions specified with --load-extension.
+  if (command_line->HasSwitch(switches::kLoadExtension)) {

[Erik does not do reviews, 2009/07/14 20:22:38]

By moving the load into here, this means you can't invoke chrome.exe with
--load-extension after chrome has already been launched.  Definitely a minor
edge case, but just wanted to make sure it was a conscious decision.

[Aaron Boodman, 2009/07/14 20:35:44]

Hmm. No, not intentional. I moved the code here so that it could be tested.
InProcessBrowserTest was not triggering it in the old location. I guess it seems
like an ok tradeoff?

[Erik does not do reviews, 2009/07/14 20:46:39]

Yep.  I think it's fine like this.

+    std::wstring path_string =
+        command_line->GetSwitchValue(switches::kLoadExtension);
+    FilePath path = FilePath::FromWStringHack(path_string);
+    extensions_service_->LoadExtension(path);
+
+    // Tell UserScriptMaser to watch this extension's directory for changes so
+    // you can live edit content scripts during development.
+    user_script_master_->AddWatchedPath(path);
+  }
 }
 
 void ProfileImpl::InitWebResources() {
   web_resource_service_ = new WebResourceService(
       this,
       g_browser_process->file_thread()->message_loop());
 
   web_resource_service_->StartAfterDelay();
 }
 
@@ skipping 572 matching lines @@
 
 void ProfileImpl::StopCreateSessionServiceTimer() {
   create_session_service_timer_.Stop();
 }
 
 #ifdef CHROME_PERSONALIZATION
 ProfilePersonalization* ProfileImpl::GetProfilePersonalization() {
   return personalization_.get();
 }
 #endif