Issue 149608: Copy of issue 155346: Change test status for x64, make test.py pass --arch to Scons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149608: Copy of issue 155346: Change test status for x64, make test.py pass --arch to Scons. (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change tests status for x64, make test runner pass --arch flag to Scons, add to x64 disassembler. Copied from http://codereview.chromium.org/155346 so it can be committed. Committed: http://code.google.com/p/v8/source/detail?r=2456

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+304 lines, -195 lines)			Patch
M	src/x64/assembler-x64.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/x64/disasm-x64.cc	View	29 chunks	+250 lines, -145 lines	0 comments	Download
M	test/cctest/cctest.status	View	3 chunks	+4 lines, -6 lines	1 comment	Download
M	test/message/message.status	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+35 lines, -34 lines	0 comments	Download
M	tools/test.py	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

This is the same change list you already reviewed, with the comments addressed.

11 years, 5 months ago (2009-07-14 11:29:25 UTC) #1

Kasper Lund

11 years, 5 months ago (2009-07-14 11:33:07 UTC) #2

LGTM.

http://codereview.chromium.org/149608/diff/1/3
File test/cctest/cctest.status (right):

http://codereview.chromium.org/149608/diff/1/3#newcode111
Line 111: test-debug/CallFunctionInDebugger: SKIP
Any reasons for skipping this rather than letting it fail, crash, timeout?

Expand Messages | Collapse Messages