Require hosts for non-file URLs.

Require hosts for non-file URLs.
BUG=9

[brettw, 2009-07-14 16:41:26]

After studying the code, it looks like file URL handling doesn't go through the
standard URL canonicalizer (though we consider them standard in some other
contexts). So I think we can just enforce no empty hosts in the standard URL
without checking for "file".

[willchan no longer on Chromium, 2009-07-14 17:23:55]

Excellent, that makes it easier.  I've updated the cl.

[brettw, 2009-07-14 17:26:33]

http://codereview.chromium.org/149588/diff/1001/11
File src/url_canon_stdurl.cc (right):

http://codereview.chromium.org/149588/diff/1001/11#newcode73
Line 73: success &= CanonicalizeHost(source.host, parsed.host,
I would call Canonicalize and then do your empty check. It may be possible for
the canonicalizer to generate something empty when given some input.

[willchan no longer on Chromium, 2009-07-14 17:35:35]

http://codereview.chromium.org/149588/diff/1001/11
File src/url_canon_stdurl.cc (right):

http://codereview.chromium.org/149588/diff/1001/11#newcode73
Line 73: success &= CanonicalizeHost(source.host, parsed.host,
On 2009/07/14 17:26:33, brettw wrote:
> I would call Canonicalize and then do your empty check. It may be possible for
> the canonicalizer to generate something empty when given some input.

Done.  Do you know of any such case?  If so, I can add it to the unittest.

[brettw, 2009-07-14 17:40:03]

LGTM

http://codereview.chromium.org/149588/diff/1001/11
File src/url_canon_stdurl.cc (right):

http://codereview.chromium.org/149588/diff/1001/11#newcode73
Line 73: success &= CanonicalizeHost(source.host, parsed.host,
No, I couldn't think of one.

[brettw, 2009-07-15 21:49:53]

Checked in as googleurl@109, I did not pull DEPS.