Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: media/filters/ffmpeg_video_decoder_unittest.cc

Issue 149573: Refactor WritableBuffer interface for more useful ptr management. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_audio_decoder.cc ('k') | media/tools/wav_ola_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_video_decoder_unittest.cc
===================================================================
--- media/filters/ffmpeg_video_decoder_unittest.cc (revision 20532)
+++ media/filters/ffmpeg_video_decoder_unittest.cc (working copy)
@@ -92,9 +92,8 @@
stream_.codec = &codec_context_;
codec_context_.width = kWidth;
codec_context_.height = kHeight;
- buffer_ = new DataBuffer();
- buffer_->GetWritableData(1);
- end_of_stream_buffer_ = new DataBuffer();
+ buffer_ = new DataBuffer(1);
+ end_of_stream_buffer_ = new DataBuffer(0);
// Initialize MockFFmpeg.
MockFFmpeg::set(&mock_ffmpeg_);
@@ -352,7 +351,7 @@
EXPECT_EQ(116, result_pts.timestamp.InMicroseconds());
EXPECT_EQ(500000, result_pts.duration.InMicroseconds());
- // Test that having pts == 0 in the frame also behaves like the pts is not
+ // Test that having pts == 0 in the frame also behaves like the pts is not
// provided. This is because FFmpeg set the pts to zero when there is no
// data for the frame, which means that value is useless to us.
yuv_frame_.pts = 0;
@@ -499,7 +498,6 @@
EXPECT_CALL(mock_ffmpeg_, AVFree(&yuv_frame_));
// Attempt the decode.
- buffer_->GetWritableData(1);
mock_decoder->codec_context_ = &codec_context_;
mock_decoder->OnDecode(buffer_);
}
« no previous file with comments | « media/filters/ffmpeg_audio_decoder.cc ('k') | media/tools/wav_ola_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698