Issue 149571: Adding Ogg/Theora/Vorbis-only FFmpeg binaries to Chromium nightly builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149571: Adding Ogg/Theora/Vorbis-only FFmpeg binaries to Chromium nightly builds. (Closed)

Created:
11 years, 5 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, Michael Moss

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Adding Ogg/Theora/Vorbis-only FFmpeg binaries to Chromium nightly builds. BUG=16657 TEST=nightly builds of Chromium should include avutil-50.dll, avformat-52.dll, avcodec-52.dll and pthreadGC2.dll

Patch Set 1 #

Patch Set 2 : Updated Linux files #

Patch Set 3 : Now with ordering! #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
M	chrome/tools/build/linux/FILES	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/tools/build/linux/FILES.official	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/tools/build/win/FILES	View	1 2	2 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Michael Moss

Can you also update the corresponding linux FILES and FILES.official, adding: libavcodec.so.52 libavformat.so.52 libavutil.so.50

11 years, 5 months ago (2009-07-13 21:46:09 UTC) #2

scherkus (not reviewing)

Actually I'm scared about the Linux ones... anyway I can test this out locally?

11 years, 5 months ago (2009-07-13 21:53:35 UTC) #4

Nicolas Sylvain

I see a failed attempt to order them alphabetically, but other than that LGTM

11 years, 5 months ago (2009-07-13 21:55:52 UTC) #5

Michael Moss

LGTM On 2009/07/13 21:53:35, scherkus wrote: > Actually I'm scared about the Linux ones... anyway ...

11 years, 5 months ago (2009-07-13 21:56:08 UTC) #6

scherkus (not reviewing)

11 years, 5 months ago (2009-07-13 22:02:11 UTC) #7

Fixed up ordering on windows

We'll see how the bots handle the linux change ;)

Expand Messages | Collapse Messages