Issue 149570: Add a temporary flag to enable plugins on the Mac and Linux while...

Issue 149570: Add a temporary flag to enable plugins on the Mac and Linux while... (Closed)

Created:
11 years, 5 months ago by Amanda Walker

Modified:
9 years, 7 months ago

Reviewers:
jon, jam, Evan Martin

CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), brettw, jam, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a temporary flag to enable plugins on the Mac and Linux while leaving the default to "disabled" until they work better. Temporary, for use by people who like living on the bleeding edge. BUG=none TEST=none jam: review evan,jon: FYI Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20540

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -5 lines)			Patch
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	1 chunk	+6 lines, -0 lines	1 comment	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_list_mac.mm	View	1 chunk	+2 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/149570/diff/1/3 File chrome/browser/tab_contents/render_view_host_delegate_helper.cc (right): http://codereview.chromium.org/149570/diff/1/3#newcode165 Line 165: prefs->GetBoolean(prefs::kWebKitPluginsEnabled); what is this pref? http://codereview.chromium.org/149570/diff/1/2 File webkit/glue/plugins/plugin_list_mac.mm ...

11 years, 5 months ago (2009-07-13 21:39:07 UTC) #3

Amanda Walker

11 years, 5 months ago (2009-07-13 23:08:45 UTC) #4

On Mon, Jul 13, 2009 at 5:39 PM, <evan@chromium.org> wrote:
> http://codereview.chromium.org/149570/diff/1/3#newcode165
> Line 165: prefs->GetBoolean(prefs::kWebKitPluginsEnabled);
> what is this pref?

It's a preexisting pref--I figured I should key off of it as the
"--disable-plugins" case does.

> http://codereview.chromium.org/149570/diff/1/2#newcode75
> Line 75: // first, test to make sure the user really wants plugins
> this comment doesn't make sense

Editing failure on my part.  Will fix in a followup CL.

Expand Messages | Collapse Messages