Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 149554: Rewrite ffmpeg_binaries target to use GYP built-ins and branding conditions. (Closed)

Created:
11 years, 5 months ago by Michael Moss
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Rewrite ffmpeg_binaries target to use GYP built-ins and branding conditions. BUG=16657

Patch Set 1 #

Patch Set 2 : remove unused helper script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -96 lines) Patch
M third_party/ffmpeg/copy_binaries.sh View 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/ffmpeg/ffmpeg.gyp View 1 chunk +27 lines, -57 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Moss
11 years, 5 months ago (2009-07-13 18:56:55 UTC) #1
scherkus (not reviewing)
LGTM thanks for looking into this -- I didn't even know about the copies directive!
11 years, 5 months ago (2009-07-13 20:57:47 UTC) #2
scherkus (not reviewing)
FYI this might trigger some test failures on the build bots, but we'll disable and ...
11 years, 5 months ago (2009-07-13 20:58:29 UTC) #3
scherkus (not reviewing)
Could you also add BUG=15906 to the description?
11 years, 5 months ago (2009-07-13 21:36:59 UTC) #4
scherkus (not reviewing)
On 2009/07/13 21:36:59, scherkus wrote: > Could you also add BUG=15906 to the description? Sorry.. ...
11 years, 5 months ago (2009-07-13 21:38:30 UTC) #5
awong
11 years, 5 months ago (2009-07-13 21:38:53 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698