Issue 149522: Add support for tracking down leak of the hole value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149522: Add support for tracking down leak of the hole value. (Closed)

Created:
11 years, 5 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add support for tracking down leak of the hole value. Committed: http://code.google.com/p/v8/source/detail?r=2432

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	src/api.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	src/ia32/codegen-ia32.cc	View		1 chunk	+10 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 5 months ago (2009-07-13 09:10:07 UTC) #2

LGTM

http://codereview.chromium.org/149522/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/149522/diff/1/2#newcode7598
Line 7598: __ cmp(Operand(eax), Immediate(Factory::the_hole_value()));
There is a cmp(Register, Handle<Object>) assembler instruction on IA32.  Same
encoding, but reads better at the call site.

Expand Messages | Collapse Messages