Issue 149487: [Mac] AcceptInput() doesn't really need focus (as when called via "Go" button).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149487: [Mac] AcceptInput() doesn't really need focus (as when called via "Go" button). (Closed)

Created:
11 years, 5 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] AcceptInput() doesn't really need focus (as when called via "Go" button). http://crbug.com/15811 TEST=Browse to www.google.com. Focus is in document. Click Go. No more crash.

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View		2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages