Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2911)

Unified Diff: chrome/browser/gtk/browser_window_gtk.cc

Issue 149486: Fix UMR caused by ActiveWindowWatcher. (Closed)
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/browser_window_gtk.cc
diff --git a/chrome/browser/gtk/browser_window_gtk.cc b/chrome/browser/gtk/browser_window_gtk.cc
index 82407470c6880a349945e2cf65b3d346b48aedb7..fc5780bb035ffba0fb10117f73b063bc0642f580 100644
--- a/chrome/browser/gtk/browser_window_gtk.cc
+++ b/chrome/browser/gtk/browser_window_gtk.cc
@@ -809,6 +809,10 @@ void BrowserWindowGtk::Observe(NotificationType type,
}
case NotificationType::ACTIVE_WINDOW_CHANGED: {
+ // Do nothing if we're in the process of closing the browser window.
+ if (!window_)
+ break;
+
const GdkWindow* active_window = Details<const GdkWindow>(details).ptr();
bool is_active = (GTK_WIDGET(window_)->window == active_window);
bool changed = (is_active != is_active_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698